Remove some manual test scaffolding#89653
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThese are either propagating unnecessary 100s or doing what the wrapper generator now does.
|
|
These were found using a hacky analyzer that looked for N-1 of a test's returns to be |
|
@TIHan PTAL cc @trylek @jkoritzinsky @dotnet/jit-contrib No analyzer changes here - just test cleanup (deleting code and some Assert.Throws) |
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Looks great to me, thanks Mark!
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Actually, @TIHan, since you also reviewed this, could you please see this one through? The issue is just veriying through outerloop (since tests might be pri 1) and extra-platforms (don't want to break mono, for example), but those jobs are often noisy and verifying them isn't immediate. |
|
@markples sure, I can try to get this through |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Rebased against latest main, tested locally, fixed wrong merge with Mark's help, rerunning lab testing, planning to merge in assuming it passes. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Merging in as the linux x64 outerloop issues are known and understood (caused by running Crossgen2 in the lab under .NET 8 Preview 7 SDK, the bug is fixed in RC1 version of the SDK). |
4 participants
These are either propagating unnecessary 100s or doing what the wrapper generator now does.