Add top level statement trimming tests #89606
Conversation
The object model wouldn't preserve declaring typesin these cases because the warnings are produced for members that are removed. Fixing the testcases to preserve these members lets us remove this workaround.
ghost
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue Detailsnull
|
sbomer
changed the title
| { | ||
| public const string TestCaseAssembly = "Mono.Linker.Tests.Cases"; | ||
|
|
||
| public void Execute (GeneratorExecutionContext context) |
src/coreclr/tools/aot/Mono.Linker.Tests/TestCasesRunner/TestCaseCollector.cs
Outdated
Show resolved
Hide resolved
| if (member is MethodDefinition method && method.Name.Contains("<Main>$")) | ||
| return false; |
There was a problem hiding this comment.
I find this a bit confusing. The IsCompilerGeneratedMember effectively dictates if we should perform "Kept" validation on the member.
I think we should instead change ShouldMethodBeKept which basically says that entry point is always kept (regardless of attributes). I wonder why the entrypoint is not set to the compiler generated main though... insteresting...
There was a problem hiding this comment.
It took me a bit to remember why I did this - it's needed for Kept validation of top-level methods. I added a clarifying comment. (I checked and the generated Main method does get treated as the entry point.)
- Remove left-over debugging output - Add comment about checking of compiler-generated top-level methods
|
Failure is #88586 |
2 participants
This adds support for top-level statements to the illink/nativeaot/trim-analyzer test infrastructure. Each file with top-level statements gets compiled into its own testcase assembly, which is placed into a subdirectory of the Mono.Linker.Tests.Cases build output.