Add check that tests are public#89554
Merged
trylek merged 11 commits intodotnet:mainfrom Aug 29, 2023
Merged
Conversation
ghost
assigned
markples
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
/azp run runtime-coreclr outerloop |
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Runtime and outerloop are clean and the runtime-extra-platforms doesn't look any worse compared to recent runs, merging in once approved :-). |
This was referenced Aug 22, 2023
jkoritzinsky
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add checks that test methods are public and in public types.
The xunit analyzers only check the latter, but our implementation requires the former as well.