[PERF] Explicitly set dotnet root when building tools#88801
Merged
LoopedBard3 merged 4 commits intodotnet:mainfrom Jul 13, 2023
Merged
[PERF] Explicitly set dotnet root when building tools#88801LoopedBard3 merged 4 commits intodotnet:mainfrom
LoopedBard3 merged 4 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsRuntime update to go along with: dotnet/performance#3137.
|
This was referenced Jul 13, 2023
cincuranet
approved these changes
Jul 13, 2023
kotlarmilos
approved these changes
Jul 13, 2023
Member
kotlarmilos
left a comment
kotlarmilos
left a comment
There was a problem hiding this comment.
Don't forget to revert the temporary changes.
LGTM!
radical
approved these changes
Jul 13, 2023
This reverts commit 1ec7e4f.
Member
Author
|
Reverted the temp changes, merging. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime update to go along with: dotnet/performance#3137.
Fixes: dotnet/performance#3136.
Working Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2220667&view=results