Implement reabstraction in CoreCLR for Static Virtual Methods#88711
Merged
davidwrighton merged 10 commits intodotnet:mainfrom Jul 14, 2023
Merged
Implement reabstraction in CoreCLR for Static Virtual Methods#88711davidwrighton merged 10 commits intodotnet:mainfrom
davidwrighton merged 10 commits intodotnet:mainfrom
Conversation
…, where EntryPointNotFound is supposed to be thrown - In addition, this should cover the late bound AmbiguousImplementationException scenario
Member
|
The issue to block the test on for NativeAOT is #72589. It didn't make sense to implement if CoreCLR proper doesn't implement it. |
trylek
reviewed
Jul 12, 2023
| case DynamicMethodDesc::StubWrapperDelegate: return "IL_STUB_WrapperDelegate_Invoke"; | ||
| case DynamicMethodDesc::StubTailCallStoreArgs: return "IL_STUB_StoreTailCallArgs"; | ||
| case DynamicMethodDesc::StubTailCallCallTarget: return "IL_STUB_CallTailCallTarget"; | ||
| case DynamicMethodDesc::StubVirtualStaticMethodDispatch: return "IL_STUB_bVirtualStaticMethodDispatch"; |
Member
There was a problem hiding this comment.
Nit - is the lowercase 'b' after IL_STUB_ intentional or just a typo?
trylek
approved these changes
Jul 12, 2023
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Looks great to me, thanks David!
Member
Author
|
Only failing issue not flagged by BuildAnalysis as known is #88870 which simply isn't being detected correctly by the BuildAnalysis stuff. |
This was referenced Jul 14, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71414