Add support to specify substitutions externally#88230
Add support to specify substitutions externally#88230MichalStrehovsky merged 3 commits intodotnet:mainfrom
Conversation
ILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well.
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well. Cc @dotnet/ilc-contrib
|
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
The changes look good.
There are some illink tests which are currently disabled for NativeAOT because of this. I think it should be possible to reenable them (with some more infra work):
https://github.com/dotnet/runtime/blob/main/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/CanWarnAsError.cs
Feel free to create an issue for that and link it to #82447. Doesn't have to be done now or as part of this PR.
Thanks! Opened #88647 and linked from the uber issue. |
2 participants
ILLinker allows specifying substitutions on the command line, same as descriptors. This can be useful for various workarounds. Add support for this for ILC as well.
Cc @dotnet/ilc-contrib