Skip to content

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Jun 17, 2023

Fixes #86885

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Jun 17, 2023
@ghost
Copy link

ghost commented Jun 17, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned tarekgh Jun 17, 2023
@tarekgh tarekgh added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 17, 2023
@tarekgh tarekgh added this to the 8.0.0 milestone Jun 17, 2023
@tarekgh
Copy link
Member Author

tarekgh commented Jun 17, 2023

@noahfalk @JamesNK could you please have a look? Thanks!

@tarekgh tarekgh merged commit 1ea78a4 into dotnet:main Jun 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix AddMetrics extension method namespace

4 participants