Fully qualify return type on UnreachableException methods #87661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsWe weren't fully qualifying the return type for shadowing stubs, causing issues if the type wasn't in the interface or a built in type.
|
jtschuster
commented
Jun 15, 2023
Member
Author
jtschuster
left a comment
jtschuster
left a comment
There was a problem hiding this comment.
Realized I probably should add a test, I will do that
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComMethodContext.cs
Outdated
Show resolved
Hide resolved
…enerator/ComMethodContext.cs Co-authored-by: Aaron Robinson <[email protected]>
AaronRobinsonMSFT
approved these changes
Jun 16, 2023
This was referenced Jun 16, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't fully qualifying the return type for shadowing stubs, causing issues if the type wasn't in the interface or a built in type.