[wasm] Fix inclusion of marshal-ilgen component
#87629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: `marshal-ilgen` component never included
Reason:
The item inclusion was being done *outside* any targets, which would get
evaluated *before* any targets are run.
But the item that it depends on to decide whether to include
`marshal-ilgen` is in target
`_ScanAssembliesDecideLightweightMarshaler`.
This broke microbenchmarks with:
```
Error: [MONO] * Assertion at /__w/1/s/src/mono/mono/component/marshal-ilgen-stub.c:28, condition `!m_type_is_byref(t)' not met
at ft (/home/helixbot/work/96640802/w/B9C40A15/e/performance/artifacts/bin/for-running/MicroBenchmarks/fa21f9df-08d0-43a4-b28d-0078821ea492/bin/net8.0/browser-wasm/AppBundle/dotnet.runtime.js:3:12422)
at mt (/home/helixbot/work/96640802/w/B9C40A15/e/performance/artifacts/bin/for-running/MicroBenchmarks/fa21f9df-08d0-43a4-b28d-0078821ea492/bin/net8.0/browser-wasm/AppBundle/dotnet.runtime.js:3:12676)
at wasm_trace_logger (wasm://wasm/00a5f7d6:wasm-function[7879]:0x1e41d0)
at eglib_log_adapter (wasm://wasm/00a5f7d6:wasm-function[581]:0x37fbb)
at monoeg_g_logv_nofree (wasm://wasm/00a5f7d6:wasm-function[504]:0x35f57)
at monoeg_assertion_message (wasm://wasm/00a5f7d6:wasm-function[508]:0x36078)
at mono_assertion_message (wasm://wasm/00a5f7d6:wasm-function[510]:0x360bb)
at stub_emit_marshal_ilgen (wasm://wasm/00a5f7d6:wasm-function[1300]:0x66db1)
at mono_emit_marshal (wasm://wasm/00a5f7d6:wasm-function[1820]:0x8990b)
at emit_native_wrapper_ilgen (wasm://wasm/00a5f7d6:wasm-function[2651]:0xb86de)
```
radical
added
arch-wasm
ghost
added
the
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIssue: Reason: But the item that it depends on to decide whether to include This broke microbenchmarks with:
|
radical
changed the title
marshal-ilgenmarshal-ilgen component
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Jun 15, 2023
Member
Author
|
The changes here affect only wasm, and the perf run for wasm. Merging this to unblock the perf pipeline. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
marshal-ilgencomponent never includedReason:
The item inclusion was being done outside any targets, which would get
evaluated before any targets are run.
But the item that it depends on to decide whether to include
marshal-ilgenis in target_ScanAssembliesDecideLightweightMarshaler.This broke microbenchmarks with: