Skip to content

[wasm] Fix running debugger tests on windows#87228

Merged
radical merged 3 commits intodotnet:mainfrom
radical:fix-dbg-win
Jun 8, 2023
Merged

[wasm] Fix running debugger tests on windows#87228
radical merged 3 commits intodotnet:mainfrom
radical:fix-dbg-win

Conversation

@radical
Copy link
Member

@radical radical commented Jun 7, 2023

.. by making sure to escape & in the command line. This was introduced
in:

commit e96321db982c3add192381f6ea4ff0a999ee1410
Author: Ilona Tomkowicz <[email protected]>
Date:   Tue Jun 6 05:59:43 2023 +0200

    [wasm][debugger] Disable failing multithreading debugger tests (#86501)

.. but missed CI due to the helix outage.

This caused all the debugger test runs on helix to fail, with timeouts, and the testResults.trx showing results only for SteppingTests.

.. by making sure to escape `&` in the command line. This was introduced
in:

```
commit e96321d
Author: Ilona Tomkowicz <[email protected]>
Date:   Tue Jun 6 05:59:43 2023 +0200

    [wasm][debugger] Disable failing multithreading debugger tests (dotnet#86501)
```

.. but missed CI due to the helix outage.
@radical radical requested a review from thaystg as a code owner June 7, 2023 19:42
@radical radical added the arch-wasm WebAssembly architecture label Jun 7, 2023
@ghost ghost added the area-Debugger-mono label Jun 7, 2023
@ghost ghost assigned radical Jun 7, 2023
@ghost
Copy link

ghost commented Jun 7, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. by making sure to escape & in the command line. This was introduced
in:

commit e96321db982c3add192381f6ea4ff0a999ee1410
Author: Ilona Tomkowicz <[email protected]>
Date:   Tue Jun 6 05:59:43 2023 +0200

    [wasm][debugger] Disable failing multithreading debugger tests (#86501)

.. but missed CI due to the helix outage.

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@radical radical requested review from ilonatommy and steveisok June 7, 2023 19:44
@radical radical added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 7, 2023
@radical radical merged commit c361f91 into dotnet:main Jun 8, 2023
@radical radical deleted the fix-dbg-win branch June 8, 2023 03:25
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Debugger-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants