Clean up GenTreeCall's inline info #86540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis PR slightly cleans up inline info for calls as a preparation for "multiple GDV candidates":
|
Member
Author
|
@AndyAyersMS PTAL, no-diffs change. Next step will be NativeAOT case where we can use the 2nd GDV candidate as a fallback (if we know that we only have 2 classes) |
AndyAyersMS
approved these changes
May 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly cleans up inline info for calls as a preparation for "multiple GDV candidates" (to reduce noise in future PRs for this):
GuardedDevirtualizationCandidateInfostruct - it used to be a base "class" forInlineCandidateInfoand is smaller in size, so were always allocated asInlineCandidateInfoanyway.uint8_t gtInlineInfoCount;field toGenTreeCall- I've checked, it doesn't increase the struct size, I inserted the field where we had a 3 bytes padding.