[wasm][debugger] Disable failing multithreading debugger tests#86501
Merged
radical merged 16 commits intodotnet:mainfrom Jun 6, 2023
Merged
[wasm][debugger] Disable failing multithreading debugger tests#86501radical merged 16 commits intodotnet:mainfrom
radical merged 16 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @thaystg Issue DetailsConnected issue: #86496
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
reviewed
May 19, 2023
Member
|
@ilonatommy but the multithreaded lane is still failing in this PR, right? |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ilonatommy
requested review from
kg,
lewing,
marek-safar and
pavelsavara
as code owners
radical
reviewed
May 22, 2023
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
I cannot reproduce any DebuggerTests_MultiThreaded on Windows. Linux's most frequent failures are blocked. |
kg
approved these changes
Jun 5, 2023
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 2e008d4.
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Use |
radical
changed the title
radical
approved these changes
Jun 5, 2023
Member
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
approved these changes
Jun 6, 2023
Member
|
Failure is unrelated. |
radical
added a commit
to radical/runtime
that referenced
this pull request
Jun 7, 2023
.. by making sure to escape `&` in the command line. This was introduced in: ``` commit e96321d Author: Ilona Tomkowicz <[email protected]> Date: Tue Jun 6 05:59:43 2023 +0200 [wasm][debugger] Disable failing multithreading debugger tests (dotnet#86501) ``` .. but missed CI due to the helix outage.
radical
added a commit
that referenced
this pull request
Jun 8, 2023
* [wasm] Fix running debugger tests on windows .. by making sure to escape `&` in the command line. This was introduced in: ``` commit e96321d Author: Ilona Tomkowicz <[email protected]> Date: Tue Jun 6 05:59:43 2023 +0200 [wasm][debugger] Disable failing multithreading debugger tests (#86501) ``` .. but missed CI due to the helix outage. * Fix escaping ! on windows
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected issue: #86496
CI is triggered by MsBuild and we had no failing category filter there. Category in
dotnet testfilter is case sensitive, should be lowercased.To clean the timeout issues with single threaded debugging tests, this PR increases the timeout to 15 minutes (3 x the original value).Increasing the timeout has no effect.