Delete gtNewBlkOpNode and lvSimdBaseJitType
#85848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBoth not needed anymore.
|
SingleAccretion
commented
May 5, 2023
src/coreclr/jit/importer.cpp
Outdated
Comment on lines
-10580
to
+10575
Contributor
Author
There was a problem hiding this comment.
volatile. is not allowed for cpobj per the specification, and we would BADCODE in impValidateMemoryAccessOpcode if we did encounter it.
SingleAccretion
force-pushed
the
No-gtNewBlkOpNode-Upstream
branch
from
ab6d821 to
54f531e
Compare
Note: neither "initobj" nor "cpobj" can be preceded by "volatile.". Delete the self-assignment handling Block morphing will fold it to a NOP anyway. I do not see the referenced liveness bug still being present. It seems to have been a remnant of COPYBLK/COPYOBJ days. Move the SIMD logic to gtNewAssignNode Delete "gtNewBlkOpNode"
SingleAccretion
force-pushed
the
No-gtNewBlkOpNode-Upstream
branch
from
4f37363 to
589aa2c
Compare
Contributor
Author
|
Diffs - one case on x86 where a SIMD local is no longer promoted. @dotnet/jit-contrib |
EgorBo
approved these changes
May 7, 2023
tannergooding
approved these changes
May 8, 2023
jakobbotsch
approved these changes
May 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both not needed anymore.