Skip to content

Conversation

@MihaZupan
Copy link
Member

Closes #82622

@MihaZupan MihaZupan added this to the 8.0.0 milestone May 2, 2023
@MihaZupan MihaZupan requested a review from stephentoub May 2, 2023 22:06
@MihaZupan MihaZupan self-assigned this May 2, 2023
@ghost
Copy link

ghost commented May 2, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 2, 2023

Tagging subscribers to this area: @dotnet/area-system-buffers
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #82622

Author: MihaZupan
Assignees: MihaZupan
Labels:

area-System.Buffers

Milestone: 8.0.0

@MihaZupan MihaZupan added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label May 2, 2023
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label May 2, 2023
@ghost
Copy link

ghost commented May 2, 2023

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@MihaZupan
Copy link
Member Author

This will break the next aspnetcore sync when merged, you will need MihaZupan/aspnetcore@e28a43b
cc: @Tratcher

@MihaZupan MihaZupan closed this May 3, 2023
@MihaZupan MihaZupan reopened this May 3, 2023
@MihaZupan MihaZupan merged commit 80739c2 into dotnet:main May 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
@MihaZupan MihaZupan removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Buffers breaking-change Issue or PR that represents a breaking API or functional change over a previous release. new-api-needs-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Rename IndexOfAnyValues

2 participants