[ILASM] Added /DET flag for deterministic compilations#85344
[ILASM] Added /DET flag for deterministic compilations#85344TIHan wants to merge 32 commits intodotnet:mainfrom
/DET flag for deterministic compilations#85344Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsResolves #8293 Part of this is from the work I did last year on the internal version of ILASM from .NET Framework.
|
TIHan
changed the title
/DET flag for deterministic compilations
|
@GrabYourPitchforks I need to use a SHA256 hash algo for all platforms, do you have any recommendations? |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
|
Re-opening as I want to finish this up. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
|
/azp run runtime-coreclr ilasm |
|
/azp run runtime-coreclr ilasm |
|
/azp run runtime-coreclr ilasm |
|
/azp run runtime-coreclr ilasm |
|
So far, I'm happy with the changes, but CI times out as I think there is a problem with how I'm constructing the debug directories. |
|
/azp run runtime-coreclr ilasm |
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| //***************************************************************************** | ||
| // sha256.cpp |
There was a problem hiding this comment.
Having our own implementation of sha256 is going to be compliance burden. You should discuss this with the security folks (email .NET Security Team).
There was a problem hiding this comment.
That's fair. Will do.
Before, I had the impl using the built-in bcrypt on windows, but I do not know an equivalent for the other OSes, other than OpenSSL. I think using OpenSSL might be overkill for this, but is there any other alternative?
|
/azp run runtime-coreclr ilasm |
|
/azp run runtime-coreclr ilasm |
|
/azp run runtime-coreclr ilasm |
|
What is the current status of this feature; was it implemented in a diff PR? |
4 participants
Description
Resolves #8293
Resolves #62484
Part of this is from the work I did two years ago on the internal version of ILASM for .NET Framework.
Additional changes:
Acceptance Criteria