Fix x64 macOS and Linux managed debugging#84655
Conversation
ghost
added
the
|
Tagging subscribers to this area: @tommcdon Issue DetailsA recent change to T_CONTEXT size breaks managed debugging. This addresses the necessary debugger API's to unblock managed debugging. Fixes #84466
|
|
This was probably caused by my thread suspend/restore changes, sorry! Is there anything we can do to catch such breaks in the future? |
|
Hi @tannergooding! No worries! We have tests in the dotnet/diagnostics repo that would catch this issue but there were unrelated problems that was preventing a runtime update. Our plan/thinking to address this in the future is to add some static asserts to the code that would at least alert folks to the debugger's dependency on context sizes. |
mikem8361
force-pushed
the
dev/tommcdon/fixx64macdbg
branch
from
38d6b34 to
24ec334
Compare
mikem8361
force-pushed
the
dev/tommcdon/fixx64macdbg
branch
from
24ec334 to
faefa50
Compare
tommcdon
left a comment
tommcdon
left a comment
There was a problem hiding this comment.
I left a few comments for your consideration otherwise the changes look good to me! I would approve the PR but I am unable to as I am the owner of it :).
3 participants
A recent change to T_CONTEXT size breaks managed debugging. This addresses the necessary debugger API's to unblock managed debugging.
Fixes #84466