Skip to content

Resolve ILLink warnings in System.Security.Cryptography.Xml#84468

Merged
eerhardt merged 3 commits intodotnet:mainfrom
eerhardt:AnnotateSSCXml
Apr 12, 2023
Merged

Resolve ILLink warnings in System.Security.Cryptography.Xml#84468
eerhardt merged 3 commits intodotnet:mainfrom
eerhardt:AnnotateSSCXml

Conversation

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Apr 7, 2023

Fix #73432

@eerhardt eerhardt requested a review from krwq April 7, 2023 02:22
@ghost
Copy link

ghost commented Apr 7, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned eerhardt Apr 7, 2023
@ghost
Copy link

ghost commented Apr 7, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #73432

Author: eerhardt
Assignees: -
Labels:

area-System.Security, new-api-needs-documentation
Milestone: -

This was referenced Apr 7, 2023
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 7, 2023
Closed
@eerhardt eerhardt mentioned this pull request Apr 7, 2023
Merged
krwq
krwq approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate but I think correct. We can also experiment with making XSL APIs safe (i.e. annotating root level APIs as safe but making them pull Xsl.Runtime namespace so that generated code can always access them). In general XSL is required by Signed XML spec so we should look at that independently.

@eerhardt eerhardt merged commit 82372ed into dotnet:main Apr 12, 2023
@eerhardt eerhardt deleted the AnnotateSSCXml branch April 12, 2023 19:43
@eerhardt eerhardt mentioned this pull request Apr 13, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjs bartonjs bartonjs left review comments

@vitek-karas vitek-karas vitek-karas left review comments

@krwq krwq krwq approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees

@eerhardt eerhardt

Labels

area-System.Security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Annotate System.Security.Cryptography.Xml for trimming

5 participants

@eerhardt @krwq @stephentoub @bartonjs @vitek-karas