Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue Detailsnull
|
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
Thanks!!!
I also found usage of 3.13 here: https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/templates/pipeline-with-resources.yml#L23-L23
I'm not sure whether that can or cannot affect Quic tests, if not that great.
| - ${{ if and(eq(parameters.platform, 'linux_musl_arm64'), or(eq(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true))) }}: | ||
| - (Alpine.313.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.13-helix-arm64v8 | ||
| - (Alpine.314.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.14-helix-arm64v8 | ||
| - (Alpine.317.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.17-helix-arm64v8 |
There was a problem hiding this comment.
There's inclusion of 3.15 and 3.17 few lines above. I'm trying to decode the conditions and difference between them:
above:
linux_musl_x64 && ( ! isExtraPlatforms || includeAllPlatforms) --> 3.15
linux_musl_x64 && ( isExtraPlatforms || includeAllPlatforms) --> 3.17
here:
linux_musl_x64 && ( isExtraPlatforms || includeAllPlatforms) --> 3.15 && 3.17
Should this be somehow collapsed into one block? Are we running twice on 3.17 thanks to this?
There was a problem hiding this comment.
I probably don't understand the comment. the section above (assuming lines 50-55) are for x86 e.g. amd64. Line 59 is for arm64 e.g. arm64v8
There was a problem hiding this comment.
Fudge, arm and amd look too similar 🤣 Nevermind then.
| - ${{ if eq(parameters.platform, 'linux_musl_x64') }}: | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - (Alpine.314.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.14-helix-amd64 | ||
| - (Alpine.315.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.15-helix-amd64 |
There was a problem hiding this comment.
We had the "newer" Alpine here. Should we then rather use 3.17 here?
Based on https://endoflife.date/alpine 3.15 will get EOLed around the time we ship 8.0.
There was a problem hiding this comment.
I'm not sure and I did not want to jump too far. Up to 3.16 Alpine uses OpenSSL 1.1 while 3.17 switched to 3.0. It may be beneficial to run both - at least for now. ASP.NET jumped on 3.16 and we may do that later before 8.0 ships. For now, I'm proposing to run on oldest(ish) supported version.
I think this is for build as it does not have the |
2 participants
contributes to #81901.
Alpine 3.13 reached EOS last year, Alpine 3.14 will reach EOS 2023-05-01 https://www.alpinelinux.org/releases/
So I updated base version with the update as well for both libraries & coreclr
Brings fix for microsoft/msquic#3448