Only call base.DisposeAsync on classes derived from FileStream#82874
Merged
Only call base.DisposeAsync on classes derived from FileStream#82874
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io |
This was referenced Mar 2, 2023
pharring
reviewed
Mar 3, 2023
wfurt
approved these changes
Mar 24, 2023
Member
wfurt
left a comment
wfurt
left a comment
There was a problem hiding this comment.
LGTM.
I'm wondering if we can write test that verifies that the file is actually closed ... perhaps by using exclusive access and opening int again after DisposeAsync or using pipes on Unix and checking EOF. Setting the CloseInvoked may be sufficient.
Member
Author
Not saying we shouldn't but I think CloseInvoked does suffice. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression introduced on #65899.
Fixes #82176.
Fixes #82186.