[browser] legacy JS interop optional via WasmEnableLegacyJsInterop - managed #82826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAllow opt-in trimming of legacy interop from managed libraries by Based on discussion with @marek-safar here #79622 (comment)
|
pavelsavara
force-pushed
the
browser_managed_legacy_interop
branch
from
5f07d4b to
9d86fac
Compare
5 tasks
marek-safar
reviewed
Mar 2, 2023
...eropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs
Outdated
Show resolved
Hide resolved
pavelsavara
changed the title
pavelsavara
force-pushed
the
browser_managed_legacy_interop
branch
from
83c6417 to
82f8b47
Compare
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
force-pushed
the
browser_managed_legacy_interop
branch
from
209942f to
3afdb87
Compare
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
reviewed
Mar 3, 2023
This was referenced Mar 3, 2023
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@radical please review, I think it's ready |
radical
approved these changes
Mar 7, 2023
...stem.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj
Show resolved
Hide resolved
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 18, 2023
maraf
pushed a commit
that referenced
this pull request
Mar 21, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow opt-in trimming of legacy interop from managed libraries
WasmEnableLegacyJsInteropMSBuild property. Default true for now.ILLink.Descriptors.LegacyJsInterop.xmland use is whenWasmEnableLegacyJsInterop==trueSystem.Runtime.InteropServices.JavaScript.LegacyExportsfrom trimmingmono_wasm_pthread_on_pthread_attachedlinking issue by reverting small part of [browser] legacy JS interop optional via WasmEnableLegacyJsInterop - native #82834This change doesn't disable the legacy interop for any scenario. There would be follow-up PR.
After Blazor change is merged, we could make the feature opt-out also for them.
See also discussion with @marek-safar