Merged
Conversation
Once runtime merges to a Roslyn toolset that has the fix for [issue 50782](dotnet/roslyn#50782) these annotations will be necessary. Front loading the work here with this change.
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsOnce runtime merges to a Roslyn toolset that has the fix for issue 50782 these annotations will be necessary. Front loading the work here with this change.
|
Member
Author
|
Can see the need for these demonstrated with #82615 where I was experimenting with latest compiler from |
RikkiGibson
approved these changes
Mar 1, 2023
stephentoub
approved these changes
Mar 1, 2023
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Unless the type is necessary to disambiguate, can all of these just be discards without the type name at all?
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/VersionConverter.cs
Outdated
Show resolved
Hide resolved
...ibraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPoolManager.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.cs
Outdated
Show resolved
Hide resolved
...System.Private.DataContractSerialization/src/System/Runtime/Serialization/DataContractSet.cs
Outdated
Show resolved
Hide resolved
...adataLoadContext/src/System/Reflection/TypeLoading/Parameters/Ecma/EcmaFatMethodParameter.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]>
Member
Author
Sure thing. Was just trying to maintain existing style. happy to move to discards. |
5 tasks
radical
added a commit
to radical/runtime
that referenced
this pull request
Mar 3, 2023
`/workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs(135,44): error CS8601: Possible null reference assignment` Started being hit with dotnet#82479 . The other instances of this were fixed in dotnet#82803 .
This was referenced Mar 3, 2023
radical
added a commit
that referenced
this pull request
Mar 3, 2023
* [wasm] Debugger tests - fix build `/workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessProxy.cs(135,44): error CS8601: Possible null reference assignment` Started being hit with #82479 . The other instances of this were fixed in #82803 . * CI: Trigger all the wasm jobs, when roslyn is updated And this includes the debugger tests
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once runtime merges to a Roslyn toolset that has the fix for issue 50782 these annotations will be necessary. Front loading the work here with this change.