[mono] Move networking code to debugger component#82785
[mono] Move networking code to debugger component#82785akoeplinger merged 3 commits intodotnet:mainfrom
Conversation
The debugger is the only component left in Mono using the networking code, move the code there so we can avoid compiling it into the main runtime and also simplify it a bit.
akoeplinger
requested review from
lambdageek,
lateralusX,
marek-safar and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
|
Tagging subscribers to this area: @thaystg Issue DetailsThe debugger is the only component left in Mono using the networking code, move the code there so we can avoid compiling it into the main runtime and also simplify it a bit.
|
| freeaddrinfo (info); | ||
| return 0; | ||
|
|
||
| #elif defined (HAVE_GETHOSTBYNAME) || defined (HAVE_GETHOSTBYNAME2) /* fallback networking code that relies on old BSD apis or whatever else is available */ |
There was a problem hiding this comment.
I wonder whether there still is any platform we care about that doesn't have getaddrinfo?
We could drop this code otherwise.
Co-authored-by: Thays Grazia <[email protected]>
|
@akoeplinger It's okay to remove/add |
|
Ok, I assume we don't use the whole debugger-component on browser/wasi right? I'll replace the #error with a runtime g_error() instead. |
3 participants
The debugger is the only component left in Mono using the networking code, move the code there so we can avoid compiling it into the main runtime and also simplify it a bit.