Replace SafeLocalAllocHandle in System.Diagnostics.PerformanceCounter
#82456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
xtqqczze
force-pushed
the
remove-SafeLocalAllocHandle2
branch
3 times, most recently
from
53e876f to
ddd8f6c
Compare
This was referenced Feb 22, 2023
xtqqczze
force-pushed
the
remove-SafeLocalAllocHandle2
branch
from
ddd8f6c to
25c0b88
Compare
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-performancecounter Issue DetailsFollow-up #82411 We don't need a Additionally change type of cc: @stephentoub
|
stephentoub
reviewed
Mar 2, 2023
...ies/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/SharedPerformanceCounter.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 2, 2023
...aries/System.Diagnostics.PerformanceCounter/src/System.Diagnostics.PerformanceCounter.csproj
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 2, 2023
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
LGTM other than two comments.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #82411
We don't need a
SafeLocalAllocHandlesince we own the handle and immediately callDangerousGetHandle.Additionally change type of
Interop+Kernel32+SECURITY_ATTRIBUTES.lpSecurityDescriptorfromIntPtrtovoid*which cleans up the code.cc: @stephentoub