Wasi icu loading #82444
Merged
Wasi icu loading #82444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2023
pavelsavara
reviewed
Feb 22, 2023
Member
pavelsavara
left a comment
pavelsavara
left a comment
There was a problem hiding this comment.
Please add src\libraries\System.Globalization\tests\System.Globalization.Tests.csproj to src\libraries\tests.proj wasi SmokeTestProject section.
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
src/mono/wasi/runtime/driver.c
Outdated
| unsigned char *buffer; | ||
| long filelen; | ||
| char filename[256]; | ||
| sprintf(filename, "%s/%s", ".", "icudt.dat"); |
Member
There was a problem hiding this comment.
this is constant string, you don't have to concatenate it here.
mkhamoyan
requested review from
SamMonoRT,
lambdageek,
marek-safar and
vargaz
as code owners
pavelsavara
reviewed
Feb 23, 2023
| char filename[256]; | ||
| sprintf(filename, "./icudt.dat"); | ||
|
|
||
| fileptr = fopen(filename, "rb"); |
Member
There was a problem hiding this comment.
fopen("./icudt.dat", "rb");
Contributor
Author
There was a problem hiding this comment.
filename is also used in lines 342 and 352.
pavelsavara
approved these changes
Feb 23, 2023
Contributor
Author
|
Failures are not related. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81908