Console.Unix: fix escape sequence for setting title on 'screen' TERM.#82340
Merged
adamsitnik merged 1 commit intodotnet:mainfrom Feb 21, 2023
Merged
Console.Unix: fix escape sequence for setting title on 'screen' TERM.#82340adamsitnik merged 1 commit intodotnet:mainfrom
adamsitnik merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
community-contribution
stephentoub
approved these changes
Feb 19, 2023
adamsitnik
approved these changes
Feb 21, 2023
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for investigating and solving the problem @tmds!
|
Tagging subscribers to this area: @dotnet/area-system-console Issue DetailsFixes #82110. This escape sequence is used in more cases with .NET 7 ( Because the escape sequence is not complete, it can cause issues when followed @adamsitnik @SteveL-MSFT @dotnet/area-system-console ptal.
|
Member
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4233106146 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82110.
This escape sequence is used in more cases with .NET 7 (
screen*vsscreen).Because the escape sequence is not complete, it can cause issues when followed
by another escape sequence, like a call to
GetCursorPosition.@adamsitnik @SteveL-MSFT @dotnet/area-system-console ptal.