Fix tests to use ConditionalFact that need it#82203
Merged
BruceForstall merged 1 commit intodotnet:mainfrom Feb 16, 2023
Merged
Fix tests to use ConditionalFact that need it#82203BruceForstall merged 1 commit intodotnet:mainfrom
BruceForstall merged 1 commit intodotnet:mainfrom
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-system-drawing Issue DetailsIn #81992 we removed On my WoA box I get a clean run of the tests now. Fixes #82141
|
BruceForstall
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #81992 we removed
[ConditionalFact]for[Fact]for a few tests inSystem.Drawing.Common, but those tests throw aSkipTestException. SkipTestException needs the ConditionalFact attribute to work (even if the class hasConditionalClass)On my WoA box I get a clean run of the System.Drawing.Common\tests now.
Fixes #82141