[wasm][debugger] Remove duplicated code and fix CI#81611
Closed
thaystg wants to merge 14 commits intodotnet:mainfrom
Closed
[wasm][debugger] Remove duplicated code and fix CI#81611thaystg wants to merge 14 commits intodotnet:mainfrom
thaystg wants to merge 14 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @thaystg |
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to 'arch-wasm': @lewing |
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 8, 2023
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
First run - no errors. |
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
thaystg
changed the title
…/runtime into thays_multithreaded_follow_up_PR
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
Member
Author
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressing @radical comments on multithreaded PR.
Some commands are repeated and we could reuse it as suggested by @radical.
Also fixing CI with latest chrome version.
First command to be sent is Debugger.enable, we wait for the answer, and then send Page.Navigate to the debugger-tests page, also wait for the answer, and then send all the other commands async.