[QUIC] Fix conditions to bin place msquic.dll for Windows builds#81490
Merged
carlossanlop merged 1 commit intomainfrom Feb 1, 2023
Merged
[QUIC] Fix conditions to bin place msquic.dll for Windows builds#81490carlossanlop merged 1 commit intomainfrom
carlossanlop merged 1 commit intomainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
Member
Author
|
/backport to release/8.0-preview1 |
Contributor
|
Started backporting to release/8.0-preview1: https://github.com/dotnet/runtime/actions/runs/4067211785 |
ManickaP
force-pushed
the
mapichov/quic-fix-win
branch
from
04e4af3 to
ddf21b8
Compare
Member
Author
|
/backport to release/8.0-preview1 |
Contributor
|
Started backporting to release/8.0-preview1: https://github.com/dotnet/runtime/actions/runs/4067254031 |
carlossanlop
approved these changes
Feb 1, 2023
Contributor
|
CI green. |
Member
|
@ManickaP thanks for fixing my mistake and adding a test to make sure this doesn't regress again in the future. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81447