Skip to content

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 18, 2023

Fixes #75711

This change updates the Unicode support to v15 and fixes some nullability issues in the tool/test code which the compiler started to complain about.

@ghost
Copy link

ghost commented Jan 18, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned tarekgh Jan 18, 2023
@tarekgh tarekgh added this to the 8.0.0 milestone Jan 18, 2023
@ghost
Copy link

ghost commented Jan 18, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #75711

This change updates the Unicode support to v15 and fixes some nullability issues in the tool/test code which the compiler started to complain about.

Author: tarekgh
Assignees: tarekgh
Labels:

area-System.Globalization

Milestone: 8.0.0

@tarekgh
Copy link
Member Author

tarekgh commented Jan 18, 2023

CC @eiriktsarpalis @krwq @layomia if any of you interested to review that too.

@tarekgh
Copy link
Member Author

tarekgh commented Jan 19, 2023

@stephentoub @joperezr could you please help this PR especially the regex changes? Thanks!

@joperezr
Copy link
Member

Thanks for doing this Tarek, I'm assuming you just followed https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/Tools/GenUnicodeProp/Updating-Unicode-Versions.md doc? If you did, did you require any additional steps or anything to update to it? Just want to make sure we keep it up-to-date for future updates.

@tarekgh
Copy link
Member Author

tarekgh commented Jan 19, 2023

Thanks for doing this Tarek, I'm assuming you just followed main/src/libraries/System.Private.CoreLib/Tools/GenUnicodeProp/Updating-Unicode-Versions.md doc? If you did, did you require any additional steps or anything to update to it? Just want to make sure we keep it up-to-date for future updates.

Yes, I have updated this file with a couple of small comments. You may have a quick look at the change in that file.

@joperezr
Copy link
Member

Oops, for whatever reason I missed those edits, thanks!

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment but looks good otherwise. Thanks @tarekgh!

@stephentoub
Copy link
Member

Thanks!

@stephentoub stephentoub merged commit 031177b into dotnet:main Jan 20, 2023
mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request Jan 24, 2023
* Support Unicode 15

* Update System.Text.Encodings.Web Unicode data

* Update Regex Unicode data

* Address the feedback
@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update .NET 8 Unicode data to version 15.0.0

3 participants