-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Support Unicode 15 #80804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Unicode 15 #80804
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsFixes #75711 This change updates the Unicode support to v15 and fixes some nullability issues in the tool/test code which the compiler started to complain about.
|
|
CC @eiriktsarpalis @krwq @layomia if any of you interested to review that too. |
|
@stephentoub @joperezr could you please help this PR especially the regex changes? Thanks! |
src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/Regex.Match.Tests.cs
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities.Unicode/System/Text/Unicode/ParsedUnicodeData.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/Tools/GenUnicodeProp/Program.cs
Outdated
Show resolved
Hide resolved
...tem.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCaseEquivalences.Data.cs
Show resolved
Hide resolved
|
Thanks for doing this Tarek, I'm assuming you just followed https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/Tools/GenUnicodeProp/Updating-Unicode-Versions.md doc? If you did, did you require any additional steps or anything to update to it? Just want to make sure we keep it up-to-date for future updates. |
Yes, I have updated this file with a couple of small comments. You may have a quick look at the change in that file. |
|
Oops, for whatever reason I missed those edits, thanks! |
joperezr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment but looks good otherwise. Thanks @tarekgh!
|
Thanks! |
* Support Unicode 15 * Update System.Text.Encodings.Web Unicode data * Update Regex Unicode data * Address the feedback
Fixes #75711
This change updates the Unicode support to v15 and fixes some nullability issues in the tool/test code which the compiler started to complain about.