[wasm] Implement more jiterpreter opcodes #80520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThese new ADD_MUL opcodes show up a lot so it's worth implementing them. Fp relop branches were supposed to be working already, but I failed to wire up the helper code properly so they weren't being generated.
|
kg
changed the title
vargaz
approved these changes
Jan 12, 2023
kg
pushed a commit
that referenced
this pull request
Feb 7, 2023
#80520 added support in the Jiterpreter for the intrinsic that underlies RuntimeHelpers.GetHashCode. This PR adds similar support for the intrinsic that underlies RuntimeHelpers.TryGetHashCode. For reference RuntimeHelpers.TryGetHashCode was added in #80059. It is currently only used in ConditionalWeakTable.TryGetValue.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new ADD_MUL opcodes show up a lot so it's worth implementing them.
Fp relop branches were supposed to be working already, but I failed to wire up the helper code properly so they weren't being generated.
Also added MINT_INTRINS_GET_HASHCODE and MINT_INTRINS_RUNTIMEHELPERS_OBJECT_HAS_COMPONENT_SIZE.