Skip to content

Adds diagnostics to detect duplicated event names in LSG#80460

Merged
tarekgh merged 1 commit intodotnet:mainfrom
allantargino:lsg/diag-reuse-event-name
Jan 11, 2023
Merged

Adds diagnostics to detect duplicated event names in LSG#80460
tarekgh merged 1 commit intodotnet:mainfrom
allantargino:lsg/diag-reuse-event-name

Conversation

@allantargino
Copy link
Contributor

fixes #64667

@ghost ghost added area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member labels Jan 10, 2023
@ghost
Copy link

ghost commented Jan 10, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #64667

Author: allantargino
Assignees: -
Labels:

area-Extensions-Logging

Milestone: -

@tarekgh tarekgh added this to the 8.0.0 milestone Jan 10, 2023
@tarekgh
Copy link
Member

tarekgh commented Jan 10, 2023

@allantargino could you please resolve the conflict?

@allantargino allantargino force-pushed the lsg/diag-reuse-event-name branch from c78a8df to 484650a Compare January 11, 2023 11:28
@allantargino
Copy link
Contributor Author

resolved @tarekgh 👍

@tarekgh tarekgh merged commit fd9f520 into dotnet:main Jan 11, 2023
@tarekgh
Copy link
Member

tarekgh commented Jan 11, 2023

Thanks @allantargino!

@allantargino allantargino deleted the lsg/diag-reuse-event-name branch January 14, 2023 14:18
@ghost ghost locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LSG] Logging Source Generator fails to detect event name uniqueness within a class scope

2 participants