Implement new ComWrappers APIs#80402
Merged
AaronRobinsonMSFT merged 14 commits intodotnet:mainfrom Jan 20, 2023
Merged
Conversation
The ComWrappers API is being expanded to enable users to get the underlying managed or unmanaged object from the created wrappers.
a wrapper is a ComWrappers impl.
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
jkotas
reviewed
Jan 10, 2023
Co-authored-by: Jeremy Koritzinsky <[email protected]>
Make GetIUnknownImpl a public API.
jkotas
reviewed
Jan 10, 2023
src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
added
area-System.Runtime.InteropServices
and removed
new-api-needs-documentation
labels
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #79674 This also adds support in NativeAOT. /cc @dotnet/interop-contrib
|
AaronRobinsonMSFT
added
new-api-needs-documentation
and removed
area-Interop-coreclr
labels
Member
Author
|
@jkoritzinsky and @elinor-fung This is green and ready for review. |
elinor-fung
approved these changes
Jan 19, 2023
src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.cs
Outdated
Show resolved
Hide resolved
...nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.NativeAot.cs
Show resolved
Hide resolved
...nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.NativeAot.cs
Outdated
Show resolved
Hide resolved
...nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.NativeAot.cs
Outdated
Show resolved
Hide resolved
...nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.NativeAot.cs
Show resolved
Hide resolved
elinor-fung
approved these changes
Jan 20, 2023
mdh1418
pushed a commit
to mdh1418/runtime
that referenced
this pull request
Jan 24, 2023
* Add TryGetComInstance and TryGetObject APIs The ComWrappers API is being expanded to enable users to get the underlying managed or unmanaged object from the created wrappers. * Add tagged interface for certainty in identifying a wrapper is a ComWrappers impl. Co-authored-by: Jeremy Koritzinsky <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79674
Fixes #79679
Fixes #80451
This also adds support in NativeAOT.
NativeAOT support for
ICustomQueryInterfaceforComWrapperswas also added.
/cc @dotnet/interop-contrib