Skip to content

Conversation

@cshung
Copy link
Contributor

@cshung cshung commented Jan 9, 2023

This change should move the test out of CI.

@ghost
Copy link

ghost commented Jan 9, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@BruceForstall
Copy link
Contributor

Related: #78899

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add this test to src\tests\issues.targets which will completely disable the test (for all the appropriate targets/platforms).

fyi, general guidance: https://github.com/dotnet/runtime/blob/main/docs/workflow/ci/disabling-tests.md

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 11, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 11, 2023
Co-authored-by: Bruce Forstall <[email protected]>
@cshung cshung merged commit eb4d230 into dotnet:main Jan 12, 2023
@cshung cshung deleted the public/disable-for-78899 branch January 12, 2023 23:14
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants