Fix failing official build #80316
Merged
Fix failing official build #80316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Official build validation at https://dev.azure.com/dnceng/internal/_build/results?buildId=2081718&view=results - hopefully my fix didn't break other things |
Member
|
/azp run runtime-wasm-non-libtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@radical the one failed test seems unrelated. Can we slap an approval on this to get it merged and un-break official builds? |
Member
Yep! I would just wait for the dotnet-runtime-official build to complete. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves official build breakage caused by #74428 (where
PackageRIDcan belinux-wasmorosx-wasminstead ofbrowser-wasmwhen/p:PortableBuild=true, butOutputRidis fine)