Skip to content

[draft][browser] enable closure compiler for dotnet.js #80178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pavelsavara wants to merge 9 commits into from
Closed

[draft][browser] enable closure compiler for dotnet.js #80178

pavelsavara wants to merge 9 commits into from

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 4, 2023 •
edited
Loading

Fixes #51524

emcc --closure 1

Release size reduction of dotnet.js
from 338118 to 274571 = 63547

7kb difference after brotli compression

@pavelsavara pavelsavara added this to the 8.0.0 milestone Jan 4, 2023
@pavelsavara pavelsavara self-assigned this Jan 4, 2023
@ghost
Copy link

ghost commented Jan 4, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Release size reduction of dotnet.js
from 338118 to 274571 = 63547

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara mentioned this pull request Jan 4, 2023
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Jan 5, 2023

image

7kb after brotli compression

@pavelsavara
Copy link
Member Author

pavelsavara commented Jan 5, 2023

With compilation_level=SIMPLE_OPTIMIZATIONS there is middle ground result.
uncompressed 310860 and 70321 brotli

ilonatommy
ilonatommy reviewed Jan 11, 2023
View reviewed changes
@pavelsavara
Copy link
Member Author

pavelsavara commented Jan 17, 2023

I should consider SIMPLE_OPTIMIZATIONS as default.

@runfoapp runfoapp bot mentioned this pull request Jan 17, 2023
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Jan 19, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

pavelsavara commented Jan 19, 2023

/azp run runtime-wasm

@ghost
Copy link

ghost commented Jan 19, 2023

Fixes #51524

emcc --closure 1

Release size reduction of dotnet.js from 338118 to 274571 = 63547

7kb difference after brotli compression

@build-analysis build-analysis bot mentioned this pull request Jan 19, 2023
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Jan 24, 2023

Closing for now. We would have to ship Java as part of the wasm-tools workload.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2023
@pavelsavara pavelsavara deleted the browser_closure branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommy ilonatommy ilonatommy left review comments

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger will be requested when the pull request is marked ready for review akoeplinger is a code owner

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[browser] Enable closure compiler for dotnet.native.js

2 participants

@pavelsavara @ilonatommy