Ensure that we don't root the compilation when using a custom exception marshalling type. #80147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on marshalling type.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThis is similar to #79051 but for the new VirtualMethodIndex generator.
|
ghost
assigned
...libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/VirtualMethodIndexData.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/VirtualMethodIndexData.cs
Outdated
Show resolved
Hide resolved
Closed
AaronRobinsonMSFT
approved these changes
Jan 5, 2023
elinor-fung
approved these changes
Jan 5, 2023
Member
elinor-fung
left a comment
elinor-fung
left a comment
There was a problem hiding this comment.
We don't currently have ComInterfaceGenerator tests that check incremental generation, right?
Member
Author
|
Not yet. We should be able to refactor our incremental tests from LibraryImportGenerator to be reusable for different generators. |
Member
Author
|
Failure is known, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #79051 but for the new VirtualMethodIndex generator.