-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Ignore SendMessageTimeout failures on Windows Nano Server #80099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| || (PlatformDetection.IsWindows && PlatformDetection.IsPrivilegedProcess); | ||
|
|
||
| // [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")] | ||
| if (PlatformDetection.IsWindowsNanoServer && target == EnvironmentVariableTarget.User) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this has to stay in SetEnvironmentVariable?
runtime/src/libraries/System.Runtime.Extensions/tests/System/Environment.SetEnvironmentVariable.cs
Line 19 in 5553691
| // [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I think that should be removed
runtime/src/libraries/System.Runtime.Extensions/tests/System/Environment.SetEnvironmentVariable.cs
Lines 19 to 23 in 5553691
| // [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")] | |
| if (target == EnvironmentVariableTarget.User && PlatformDetection.IsWindowsNanoServer) | |
| { | |
| return false; | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I thought setting per-user env vars worked, but only for the current process. So these two tests ought to pass, as it's all in the same process. You've made them skip though?
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
NativeAOT_Libs failures are #79453 |
Fixes #30566