Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Jan 2, 2023

Fixes #30566

@ghost ghost added the area-System.Runtime label Jan 2, 2023
@ghost ghost assigned jkotas Jan 2, 2023
@ghost
Copy link

ghost commented Jan 2, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #30566

Author: jkotas
Assignees: -
Labels:

area-System.Runtime

Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Jan 2, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

|| (PlatformDetection.IsWindows && PlatformDetection.IsPrivilegedProcess);

// [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")]
if (PlatformDetection.IsWindowsNanoServer && target == EnvironmentVariableTarget.User)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this has to stay in SetEnvironmentVariable?

// [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I think that should be removed

// [ActiveIssue("https://github.com/dotnet/runtime/issues/30566")]
if (target == EnvironmentVariableTarget.User && PlatformDetection.IsWindowsNanoServer)
{
return false;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I thought setting per-user env vars worked, but only for the current process. So these two tests ought to pass, as it's all in the same process. You've made them skip though?

@jkotas
Copy link
Member Author

jkotas commented Jan 3, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Jan 3, 2023

NativeAOT_Libs failures are #79453

@jkotas jkotas merged commit 6c2b939 into dotnet:main Jan 3, 2023
@jkotas jkotas deleted the issue-30566 branch January 3, 2023 17:26
@ghost ghost locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnvironmentVariable operations with EnvironmentVariableTarget.User fails on Windows Nano Server

2 participants