Skip to content

Add NativeAOT checked leg #79847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalStrehovsky merged 8 commits into from
Jan 2, 2023
Merged

Add NativeAOT checked leg #79847

MichalStrehovsky merged 8 commits into from
Jan 2, 2023

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Dec 20, 2022

This is the same as the release leg, but checked runtime and on fewer queues (only Win x64 and Linux arm64).

Cc @dotnet/ilc-contrib

@MichalStrehovsky
Add NativeAOT checked leg
d9f747b 
This is the same as the release leg, but checked runtime and on fewer queues (only Win x64 and Linux arm64).
@ghost
Copy link

ghost commented Dec 20, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@MichalStrehovsky MichalStrehovsky mentioned this pull request Dec 20, 2022
Closed
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Dec 20, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 20, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Dec 20, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This is the same as the release leg, but checked runtime and on fewer queues (only Win x64 and Linux arm64).

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-Infrastructure
Milestone: -

This was referenced Dec 20, 2022
Closed
Closed
@MichalStrehovsky
Try bumping the timeout
61f9c2d 
Checked RyuJIT is a lot slower than the rest of the checked system :/
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Dec 23, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 23, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Dec 23, 2022
Closed
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Dec 30, 2022

If I'm reading this right, we're taking a codepath on Windows Nano that we should not be taking on Nano.

Going to debug this in the CI since I have no clue how to easily get a Nano environment.

Unhandled Exception: System.Diagnostics.DebugProvider+DebugAssertException: SetEnvironmentVariable failed: 0
   at System.Diagnostics.DebugProvider.Fail(String, String) + 0x36
   at System.Diagnostics.Debug.Fail(String, String) + 0x21
   at System.Environment.SetEnvironmentVariableFromRegistry(String variable, String value, Boolean fromMachine) + 0x184
   at System.Environment.SetEnvironmentVariable(String variable, String value, EnvironmentVariableTarget target) + 0x6c
   at System.Tests.GetEnvironmentVariable.EnumerateEnvironmentVariables(EnvironmentVariableTarget target) + 0x148

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Dec 30, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 30, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Dec 30, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 30, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Jan 2, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 2, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Jan 2, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 2, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky MichalStrehovsky mentioned this pull request Jan 2, 2023
Closed
@MichalStrehovsky MichalStrehovsky merged commit 233a14d into dotnet:main Jan 2, 2023
@MichalStrehovsky MichalStrehovsky deleted the chkleg branch January 2, 2023 05:13
@runfoapp runfoapp bot mentioned this pull request Jan 2, 2023
Open
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

@MichalStrehovsky MichalStrehovsky

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalStrehovsky @akoeplinger