Use LockFreeReaderHashtable for some of the NodeCaches #79805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not replacing everything because the only reason this has better perf than `ConcurrentDictionary` is that the API surface is totally unergonomic. These are the heaviest hitters.
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsNot replacing everything because the only reason I'm seeing ~4% wallclock time throughput improvement when compiling hello world. (Measured with ILC-compiled ILC, because getting stable-ish TP numbers with CoreCLR-hosted ILC has become impossible). cc @dotnet/ilc-contrib
|
jkotas
approved these changes
Dec 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not replacing everything because the only reason
LockFreeReaderHashtablehas better perf thanConcurrentDictionaryis that the API surface is totally unergonomic. These nodes are the heaviest hitters.I'm seeing ~4% wallclock time throughput improvement when compiling hello world. (Measured with ILC-compiled ILC, because getting stable-ish TP numbers with CoreCLR-hosted ILC has become impossible).
cc @dotnet/ilc-contrib