Remove manual DLL copy from ILCompiler build task #79783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than manually copying DLLs from the NuGet package directory we can just set an MSBuild property to copy package dependencies to the build output. This is also safer since it includes all the transitive dependencies.
ghost
added
the
jkotas
reviewed
Dec 17, 2022
src/coreclr/tools/aot/ILCompiler.Build.Tasks/ILCompiler.Build.Tasks.csproj
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Dec 17, 2022
…Tasks.csproj Co-authored-by: Jan Kotas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than manually copying DLLs from the NuGet package directory we can just set an MSBuild property to copy package dependencies to the build output. This is also safer since it includes all the transitive dependencies.