Skip to content

Delete some commented tests#79742

Merged
jakobbotsch merged 3 commits intodotnet:mainfrom
jakobbotsch:fix-4680
Dec 17, 2022
Merged

Delete some commented tests#79742
jakobbotsch merged 3 commits intodotnet:mainfrom
jakobbotsch:fix-4680

Conversation

@jakobbotsch
Copy link
Member

Fix #4680

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 16, 2022
@ghost ghost assigned jakobbotsch Dec 16, 2022
@ghost
Copy link

ghost commented Dec 16, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #4680

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests aren't going to pass since they rely on being able to marshal System.Object. The default marshalling for System.Object is Windows-only since it's COM marshalling. These tests should be disabled on non-Windows in a more standard manner (just check if(OperatingSystem.IsWindows()))

@jkoritzinsky
Copy link
Member

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalPetryka
Copy link
Contributor

These tests aren't going to pass since they rely on being able to marshal System.Object. The default marshalling for System.Object is Windows-only since it's COM marshalling. These tests should be disabled on non-Windows in a more standard manner (just check if(OperatingSystem.IsWindows()))

Wouldn't PlatformDetection.IsBuiltInComEnabled Be better here?

@jakobbotsch
Copy link
Member Author

These tests aren't going to pass since they rely on being able to marshal System.Object. The default marshalling for System.Object is Windows-only since it's COM marshalling. These tests should be disabled on non-Windows in a more standard manner (just check if(OperatingSystem.IsWindows()))

Thanks! I just deleted them, this test is under systemvbringup folder and seems more focused on the JIT's passing of structs that fit in registers.

@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member Author

Now this is just deleting commented code so I guess there is no point in running outerloop.

@jakobbotsch jakobbotsch changed the title (Re)enable some SysV pinvoke tests Delete some commented tests Dec 16, 2022
@jakobbotsch jakobbotsch merged commit c90a2e8 into dotnet:main Dec 17, 2022
@jakobbotsch jakobbotsch deleted the fix-4680 branch December 17, 2022 09:08
@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the disabled tests in the System V struct passing tests when Issue #2075 is resolved

4 participants