Don't require singlefilehost in host.native #79565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The corehost project currently tries to build the singlefilehost with the embedded DAC, which we can skip if we never built the singlefilehost in the first place.
ghost
added
the
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsThe corehost project currently tries to build the singlefilehost with the embedded DAC, which we can skip if we never built the singlefilehost in the first place.
|
jkoritzinsky
approved these changes
Dec 13, 2022
Member
|
You were getting these errors: .packages/microsoft.dotnet.build.tasks.packaging/8.0.0-beta.22606.1/build/Packaging.targets(1261,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error when creating nuget lib package from /__w/1/s/artifacts/packages/Debug/specs/runtime.linux-musl-arm64.Microsoft.NETCore.DotNetAppHost.nuspec. NuGet.Packaging.Core.PackagingException: File not found: '/__w/1/s/artifacts/bin/linux-musl-arm64.Debug/corehost/singlefilehost'.
at NuGet.Packaging.PackageBuilder.AddFiles(String basePath, String source, String destination, String exclude)
at NuGet.Packaging.PackageBuilder.PopulateFiles(String basePath, IEnumerable`1 files)
at Microsoft.DotNet.Build.Tasks.Packaging.NuGetPack.Pack(String nuspecPath, String nupkgPath, Manifest manifest, Boolean packSymbols) in /_/src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetPack.cs:line 261I moved the condition to the other target as the Nit: The |
ViktorHofer
approved these changes
Dec 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corehost project currently tries to build the singlefilehost with the embedded DAC, which we can skip if we never built the singlefilehost in the first place.
Fixes #79144