Ignoring test regression runtime_63354 in x86 #79358
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BrianBohe
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIgnoring the test for the moment until solving the issue
|
src/tests/issues.targets
Outdated
| <ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/Runtime_31615/Runtime_31615/*"> | ||
| <Issue>https://github.com/dotnet/runtime/issues/79170</Issue> | ||
| </ExcludeList> | ||
| <ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/Runtime_63354/Runtime_63354/*"> |
There was a problem hiding this comment.
The file is JIT\Regression\JitBlue\Runtime_63354\Runtime_63354.csproj, not sure how it would work with this wildcard. I see that they are used at other places too. But shouldn't it be $(XunitTestBinBase)/JIT/Regression/JitBlue/Runtime_63354/**?
There was a problem hiding this comment.
There are only two files on that directory (src\tests\JIT\Regression\JitBlue\Runtime_63354), we could add the ** to be sure anyway
| <Issue>https://github.com/dotnet/runtime/issues/79170</Issue> | ||
| </ExcludeList> | ||
| <ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/Runtime_63354/Runtime_63354/*"> | ||
| <ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/Runtime_63354/Runtime_63354/**"> |
There was a problem hiding this comment.
I think it should be JitBlue/Runtime_63354/** (no 2nd Runtime_63354) but Bruce or someone else can confirm.
There was a problem hiding this comment.
I am okey with either waiting or merging and monitoring. I think it does not worth to trigger the stress pipeline again here if it takes too long for it to finish
There was a problem hiding this comment.
The two Runtime_63354s come from the directory name and then the project file name. Runtime_63354/** is going to include Runtime_63354/Runtime_63354/* since ** is a multi-level wildcard. I'm guessing that the final * is to cover the specific test names (like if you have multiple [Fact]s in the project, but I'm not sure about that part.
This reverts commit 1dec648.
* Adding jitdump for varible debug info * Forcing home and live update after SIMD12 store lcl Although LSRA is indicating the tree produces the result in an xmm's register, we are storing vector3 always on stack, so its home on varDsc and liveness information must be recorded accordingly. LSRA seems not to has this information. * Formatting file * Add missing case of targetReg in genStoreLclTypeSIMD12() * Fix liveness update for genStoreLclFld() and genStoreLclVar on x64 * Fix liveness update for genStoreLclTypeSIMD12() on arm64 * Fix and unifying genStoreLclFld/LclVar on x64 * Revert "Ignoring test regression runtime_63354 in x86 (#79358)" This reverts commit 1dec648. Co-authored-by: Brian Bohe <[email protected]> Co-authored-by: Kunal Pathak <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
3 participants
Ignoring the test for the moment until solving the issue 78898