Teach internal printf about 'z'
#78685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous PR, an attempt was made to remove most Windows specific format flags. However, the internal printf version we are using doesn't know about the 'z' flag. In order to transition to the correct flags so we can remove our printf, we need to teach our printf about modern flags.
ghost
assigned
jakobbotsch
approved these changes
Nov 22, 2022
Member
jakobbotsch
left a comment
jakobbotsch
left a comment
There was a problem hiding this comment.
Interesting, I guess this means the places we have in the JIT that were using %z were broken on non-Windows (there's a handful of those)
janvorli
reviewed
Nov 22, 2022
janvorli
approved these changes
Nov 22, 2022
Member
Author
|
Failure is #78718 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78623
Caused by #78434
In a previous PR, an attempt was made to remove
most Windows specific format flags. However, the
internal
printfversion we are using doesn't knowabout the 'z' flag. In order to transition to the correct
flags, so we can remove our
printf, we need to teachour
printfabout modern flags./cc @markples @janvorli