SPMI: Implement fallback schema layout#78594
Conversation
Fallback to doing actual layout of the schema data when the schema does not match the recorded schema. This ensures replays are still consistent with the recording in cases where the JIT and environment variables match, but that we can still succeed a replay on changes to these. Fix dotnet#74718
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFallback to doing actual layout of the schema data when the schema does not match the recorded schema. This ensures replays are still consistent with the recording in cases where the JIT and environment variables match, but that we can still succeed a replay on changes to these. Fix #74718
|
|
I still need to double check why inlining has an impact on the requested schema. |
Hmm, I actually cannot reproduce this anymore, even with this change reverted. @SingleAccretion does it still reproduce for you? |
|
@jakobbotsch just checked, it doesn't. |
|
cc @dotnet/jit-contrib |
|
/azp run runtime-coreclr superpmi-asmdiffs-checked-release |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@EgorBo can you take a look at this? |
EgorBo
left a comment
EgorBo
left a comment
There was a problem hiding this comment.
Interesting, curious why we didn't see any asserts/crashes before
It's pretty rare that the schema is different, but we have seen those in a few cases |
3 participants
Fallback to doing actual layout of the schema data when the schema does not match the recorded schema. This ensures replays are still consistent with the recording in cases where the JIT and environment variables match, but that we can still succeed a replay on changes to these.
Fix #74718