[PERF]Make mono dotnet pathing dynamic#78581
Closed
LoopedBard3 wants to merge 3 commits intodotnet:mainfrom
Closed
[PERF]Make mono dotnet pathing dynamic#78581LoopedBard3 wants to merge 3 commits intodotnet:mainfrom
LoopedBard3 wants to merge 3 commits intodotnet:mainfrom
Conversation
This reverts commit 259172133e5fa220c14e032d6b328138e6f22721.
LoopedBard3
requested review from
DrewScoggins,
caaavik-msft,
cincuranet and
sblom
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsPR to update for: dotnet/performance#2733. This changes the product versions in the mono-dotnet creation paths to be generated from the eng/Versions.props file instead of having to be manually updated.
|
3 tasks
cincuranet
approved these changes
Nov 21, 2022
Contributor
cincuranet
left a comment
cincuranet
left a comment
There was a problem hiding this comment.
@LoopedBard3 The change, the part where you parse out the version, LGTM.
But I'm not a fan of "manually" parsing the file. IMO offloading that to MSBuild, because that file is already processed by MSBuild in other places, makes it more robust/compatible down the line (something what I described here). But that's my personal preference.
Member
Author
|
Closing in favor of #78787 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to update for: dotnet/performance#2733. This changes the product versions in the mono-dotnet creation paths to be generated from the eng/Versions.props file instead of having to be manually updated.