Updating CreateScalar to be intrinsic for Vector64/128/256 #77798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis ensures that vector constant nodes can be created and improves the codegen for inserts involving float. Handling for
|
Member
Author
|
CC. @dotnet/jit-contrib |
Member
Author
|
/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr jitstress-isas-arm, runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Nov 3, 2022
TIHan
reviewed
Nov 3, 2022
TIHan
reviewed
Nov 3, 2022
Member
Author
|
|
EgorBo
reviewed
Nov 7, 2022
EgorBo
reviewed
Nov 7, 2022
EgorBo
approved these changes
Nov 7, 2022
Member
Author
|
CI failures are currently dotnet/arcade#11554. However, there is no way to tell if its masking actual issues or not so I'll hold off on merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that vector constant nodes can be created and improves the codegen for inserts involving float.
Handling for
Create(Vector128<T> lower, Vector128<T> upper)also needs to be done, but will be a separate PR.