[wasm] browser profiler (again) #77779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
pavelsavara
requested review from
BrzVlad,
SamMonoRT,
lambdageek,
lewing,
marek-safar,
radical,
thaystg and
vargaz
as code owners
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis is second attempt to merge #77449 which was reverted. I tested with v8 10.9.130 and V8 10.7.193 and NodeJS v16.13.1.
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
approved these changes
Nov 2, 2022
Member
|
wbt failure: |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Failures are unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is second attempt to merge #77449 which was reverted.
On top of previous change I also fix for the different signature on
performance.measureAPI on the V8 and NodeJS shell.I tested with v8 10.9.130 and V8 10.7.193 and NodeJS v16.13.1.