Fix the __int64 to be long long on macOS only #77268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that my recent change to redefine __int64 on Unix is actually correct for macOS only. For other 64 bit Unixes, the __int64 should be defined as long. This change fixes it.
Member
Author
jkotas
approved these changes
Oct 20, 2022
AaronRobinsonMSFT
approved these changes
Oct 20, 2022
mangod9
approved these changes
Oct 20, 2022
Member
|
looks like the super-pmi rerun is red due to failure to upload logs, the tests actually passed. Guessing its ok to merge? |
mangod9
pushed a commit
to mangod9/runtime
that referenced
this pull request
Nov 10, 2022
It turned out that my recent change to redefine __int64 on Unix is actually correct for macOS only. For other 64 bit Unixes, the __int64 should be defined as long. This change fixes it.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that my recent change to redefine __int64 on Unix is actually correct for macOS only. For other 64 bit Unixes, the __int64 should be defined as long.
This change fixes it.