get rid of saved_allocated #77197
get rid of saved_allocated #77197
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsI thought incorrectly when I made the change to use
|
|
Would this help reduce impact on |
|
@mangod9 yes, I ran the simple string test and verified that it fixes the remaining regression. we'll be running more microbenchmarks. |
|
@Maoni0, is this PR still relevant? |
|
it is. I just didn't have time to take care of it. will do so soon. |
|
@Maoni0, looking at old PRs... should this be closed? |
|
I'm closing this for now. I've added this to my list of items to keep track of. |
3 participants
I thought incorrectly when I made the change to use
saved_allocatedto calculate the frag ratio - this frag ratio actually should use theallocatedthat's adjusted by the plan phase, not the originalallocatedfor theheap_segment. this can affect microbenchmarks dramatically when the last live object is way smaller thanallocated, instead of doing a sweeping GC (which is the right choice) we ended up doing a compacting GC because we'd be calculating a very large frag ratio when we calldecide_on_compacting.